Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow configuring of tab titles #319

Merged
merged 25 commits into from
Feb 11, 2024
Merged

Allow configuring of tab titles #319

merged 25 commits into from
Feb 11, 2024

Conversation

felixhabib
Copy link
Contributor

@felixhabib felixhabib commented Feb 1, 2024

It is hard to distinguish between Playroom tabs when there is more than one in the same window.
image

This change:

  • Adds a "Title" section in the settings pane which allows you to customise the tab title.
  • Saves Titles in the URL.
  • Updates spacing scale logic.
  • Removes dividers in all menus for consistent visual treatment.

For example

image

Copy link

changeset-bot bot commented Feb 1, 2024

🦋 Changeset detected

Latest commit: 831e1f3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
playroom Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@felixhabib felixhabib marked this pull request as ready for review February 2, 2024 01:58
@felixhabib felixhabib requested a review from a team as a code owner February 2, 2024 01:58
@felixhabib felixhabib marked this pull request as draft February 2, 2024 02:06
@felixhabib felixhabib marked this pull request as ready for review February 2, 2024 02:48
@felixhabib felixhabib marked this pull request as draft February 4, 2024 23:59
@felixhabib felixhabib marked this pull request as ready for review February 6, 2024 04:20
Co-authored-by: Michael Taranto <[email protected]>
@felixhabib felixhabib requested a review from benjervis February 9, 2024 05:49
@felixhabib felixhabib merged commit f45dd04 into master Feb 11, 2024
6 checks passed
@felixhabib felixhabib deleted the add-titles branch February 11, 2024 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants