Simplify debug build check logic #885
Conversation
Signed-off-by: HeroBuxx <[email protected]>
| @@ -193,7 +193,7 @@ const val ERROR_BACKUP_CANCELLED: Int = BackupManager.ERROR_BACKUP_CANCELLED | |||
| const val ERROR_BACKUP_NOT_ALLOWED: Int = BackupManager.ERROR_BACKUP_NOT_ALLOWED | |||
|
|
|||
| // TODO this doesn't work for LineageOS as they do public debug builds | |||
| fun isDebugBuild() = Build.TYPE == "userdebug" || Build.TYPE == "eng" | |||
| fun isDebugBuild() = Build.TYPE != "user" | |||
There was a problem hiding this comment.
I don't know enough about possible build types, but it seems to me making debug builds explicit is safer than declaring everything a debug build which isn't user. Also considering that certain safety features are disabled in debug builds.
There was a problem hiding this comment.
There are only three build variants: user, userdebug, and eng.
Since userdebug and eng are both debugging builds, classifying any variant other than user as a debugging build would simplify code readability.
There was a problem hiding this comment.
what if there is ever a new build variant introduced?
There was a problem hiding this comment.
Only those 3 variants have existed in the ~17 years of android being public.
I am not sure if this change is worth making, it doesn't actually fix something and the TODO above is still valid, LineageOS and other downstream forks will still have to modify this check to just Build.TYPE == "eng"
Since there only one non-debugging build variant, i think it's better to keep it simple