Skip to content

Fix: withdrawal frontrun #272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 13, 2025
Merged

Fix: withdrawal frontrun #272

merged 1 commit into from
Mar 13, 2025

Conversation

gluax
Copy link
Collaborator

@gluax gluax commented Mar 11, 2025

Motivation

So you cannot frontrun withdrawing.

Explanation of Changes

  • Adds the withdraw address to the withdraw payload.
  • modifies the hashes accordingly

Testing

Two new tests added that pass.

Related PRs and Issues

N/A

@gluax gluax requested review from Thomasvdam and mariocao March 11, 2025 17:25
@gluax gluax self-assigned this Mar 11, 2025
@gluax gluax changed the base branch from fix-review to dev March 11, 2025 17:26
@gluax gluax changed the base branch from dev to chore/integrate-common-to-repo March 12, 2025 16:18
@gluax gluax force-pushed the fix/withdrawl-frontrun branch from 01b09e1 to 6b80efb Compare March 12, 2025 16:21
Copy link

Code Coverage

Package Line Rate Complexity Health
contract.src.msgs.staking 96% 0
common.src.msgs.data_requests.execute 100% 0
contract.src.msgs.staking.state 96% 0
contract.src.msgs 93% 0
contract.src.msgs.data_requests.execute 100% 0
contract.src.msgs.data_requests 86% 0
common.src.msgs.owner 100% 0
common.src.msgs.staking.query 100% 0
common.src.msgs.data_requests.sudo 100% 0
common.src.msgs.staking.execute 100% 0
contract.src.msgs.data_requests.sudo 98% 0
common.src.msgs.owner.execute 100% 0
common.src.msgs.staking 100% 0
contract.src.msgs.owner.execute 96% 0
contract.src.msgs.staking.execute 97% 0
common.src 100% 0
common.src.msgs.data_requests 99% 0
common.src.types 59% 0
contract.src.msgs.owner 100% 0
common.src.msgs 100% 0
contract.src 81% 0
contract.src.msgs.data_requests.state 98% 0
Summary 96% (4224 / 4416) 0

@mariocao mariocao changed the title Fix: withdrawl frontrun Fix: withdrawal frontrun Mar 13, 2025
Base automatically changed from chore/integrate-common-to-repo to fix-review March 13, 2025 16:21
@gluax gluax merged commit 6b80efb into fix-review Mar 13, 2025
2 checks passed
@gluax gluax deleted the fix/withdrawl-frontrun branch March 13, 2025 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants