Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor AppendError to check for build.NoGoError #1273

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

alexandear
Copy link
Contributor

This PR refactors Analyzer.AppendError to handle build.NoGoError for non-buildable packages. It's better to check for specific error instead of string.

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.62%. Comparing base (1216c9b) to head (a89b7b7).
Report is 27 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1273      +/-   ##
==========================================
- Coverage   68.49%   66.62%   -1.88%     
==========================================
  Files          75       75              
  Lines        4384     5190     +806     
==========================================
+ Hits         3003     3458     +455     
- Misses       1233     1583     +350     
- Partials      148      149       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

analyzer.go Show resolved Hide resolved
@alexandear alexandear requested a review from ccojocar December 19, 2024 10:33
@ccojocar ccojocar merged commit 36c81ed into securego:master Dec 19, 2024
6 checks passed
@alexandear alexandear deleted the refactor/no-go-err branch December 19, 2024 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants