Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add responsiveness and accessibility #137

Merged
merged 2 commits into from
Mar 3, 2024
Merged

Conversation

tim0-12432
Copy link
Contributor

1. Responsiveness

Mobile Desktop
localhost_5173_StreamAwesome_ localhost_5173_StreamAwesome_ (1)

2. Accessibility

  • Added tabindex for good tabbing navigation experience (only 1 change necessary)
  • Added consistent focus indicator on inputs
  • No additional aria-labels necessary

@sebinside sebinside added bug Something isn't working enhancement New feature or request support Does enhance the experience without changing the icon generator labels Feb 20, 2024
@sebinside sebinside self-assigned this Feb 20, 2024
@sebinside sebinside added this to the v2.0.0 milestone Feb 20, 2024
@sebinside
Copy link
Owner

Just a quick note: From looking at the code, everything looks fine but I have to test one thing in production which delays the merging until the next stream.

@tim0-12432 In the meantime: Could you please target the develop branch and not the main branch with this PR? Thank you!

@tim0-12432 tim0-12432 changed the base branch from main to develop February 27, 2024 15:41
@sebinside sebinside merged commit 8d45cb7 into sebinside:develop Mar 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request support Does enhance the experience without changing the icon generator
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants