Keep information which data provider provided current data set #5992
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… of more generic tests
… of more generic tests
# Conflicts: # src/Metadata/Api/DataProvider.php # tests/end-to-end/event/testwith-annotation.phpt # tests/end-to-end/regression/4625.phpt
sebastianbergmann
added
type/enhancement
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5992 +/- ##
============================================
- Coverage 94.67% 94.66% -0.02%
- Complexity 6406 6415 +9
============================================
Files 694 694
Lines 19189 19200 +11
============================================
+ Hits 18167 18175 +8
- Misses 1022 1025 +3 ☔ View full report in Codecov by Sentry. |
cover function TestCase::getProviderName()
sebastianbergmann
force-pushed
the
main
branch
from
da21665 to
4dddc8c
Compare
sebastianbergmann
force-pushed
the
main
branch
4 times, most recently
from
1bb9097 to
5af6639
Compare
# Conflicts: # src/Metadata/Api/DataProvider.php # tests/unit/Metadata/Api/DataProviderTest.php
Owner
|
@staabm You might be interested in this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For better error messages and lookup capability the names of data providers are kept. First in the existing data set structure then in InvalidDataProviderException if thrown and in the TestCase itself.
When you have multiple data providers for a test function it is really helpful to know which one is invalid, and you do not always start off with named sets.
Because this PR is about error messages a lot of own tests are affected.