Merge pull request #9 from seatable/fix-custom-share-perm

fix custom share perm

docker/Dockerfile

@@ -26,7 +26,7 @@ RUN rm -f /usr/bin/python && \
     ln -s /usr/local/bin/pip3.6 /usr/bin/pip && \
     ln -s /usr/local/bin/pip3.6 /usr/bin/pip3
 
-RUN pip3 install uvicorn pillow pymysql sqlalchemy future requests \
+RUN pip3 install uvicorn pillow sqlalchemy==1.4.6 pymysql future requests \
     -i https://mirrors.aliyun.com/pypi/simple && rm -r /root/.cache/pip
 
 

requirements.txt

@@ -1,7 +1,7 @@
 uvicorn
 pillow
+sqlalchemy==1.4.6
 pymysql
-sqlalchemy
 future  # seaf-server
 requests
 

seatable_thumbnail/permissions.py

@@ -18,16 +18,17 @@ def check(self):
     def has_dtable_asset_read_permission(self):
         # three ways to access asset
         # 1. through external link to get image
-        # 2. through dtable perm, including dtable share
-        # 3. through view share perm
+        # 2. through collection table to get image
+        # 3. through dtable perm, including dtable share, dtable custom share
+        # 4. through view share perm
 
         if self.can_access_image_through_external_link():
             return True
         if self.has_collection_table_permission():
             return True
-        if 'r' in self.check_dtable_permission():
+        if self.check_dtable_permission():
             return True
-        if 'r' in self.get_view_share_permission():
+        if self.get_view_share_permission():
             return True
 
         return False