refactor import/sync drop dtable-server view-rows #429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexCXC
force-pushed
the
CDS-drop-server-rows
branch
from
ce93511 to
84a09d3
Compare
AlexCXC
force-pushed
the
CDS-drop-server-rows
branch
from
84a09d3 to
173a3f6
Compare
JoinTyang
reviewed
Mar 1, 2023
| if not src_view: | ||
| set_common_dataset_invalid(dataset_id, db_session) | ||
| set_common_dataset_sync_invalid(dataset_sync_id, db_session) | ||
| logging.error('Source view not found.') |
| except Exception as e: | ||
| logging.error('request dst dtable: %s error: %s', dst_dtable_uuid, e) | ||
| return | ||
| src_enable_archive = (src_dtable_metadata.get('settings') or {}).get('enable_archive', False) |
| @@ -533,298 +540,376 @@ def generate_single_row(converted_row, src_row, src_columns, transfered_columns_ | |||
| if not transfered_column: | |||
| continue | |||
|
|
|||
| if to_archive and col['key'] in ['_creator', '_ctime', '_last_modifier', '_mtime']: | |||
| return { | ||
| 'dst_table_id': None, | ||
| 'error_msg': 'update rows error', | ||
| 'task_status_code': 500 | ||
| } | ||
|
|
||
|
|
||
| def delete_dst_rows(dst_dtable_uuid, dst_table_name, to_be_deleted_row_ids, dst_dtable_db_api, dst_dtable_server_api, to_archive): |
There was a problem hiding this comment.
归档和非归档数据都可以使用dtable-db的接口删除
| updates = [] | ||
| for row in to_be_updated_rows[i: i+step]: | ||
| updates.append({ | ||
| def update_dst_rows(dst_dtable_uuid, dst_table_name, to_be_updated_rows, dst_dtable_db_api, dst_dtable_server_api, to_archive): |
There was a problem hiding this comment.
归档和非归档数据都可以使用dtable-db的接口更新
AlexCXC
force-pushed
the
CDS-drop-server-rows
branch
from
59815e1 to
a38891e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.