Update TS and eslint packages #241
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for remix-forms canceled.
|
gustavoguichard
force-pushed
the
update-ts-eslint
branch
from
faad7a8
to
7fa5efd
Compare
gustavoguichard
commented
May 3, 2024
Comment on lines
+10
to
+11
| ? ObjectFromSchema<R> | ||
| : never |
There was a problem hiding this comment.
Upgrading prettier required this
gustavoguichard
commented
May 3, 2024
| @@ -114,7 +114,7 @@ async function getFormValues<Schema extends FormSchema>( | |||
| return values | |||
| } | |||
|
|
|||
| async function performMutation<Schema extends FormSchema, D extends unknown>({ | |||
| async function performMutation<Schema extends FormSchema, D>({ | |||
There was a problem hiding this comment.
There's this eslint rule that was complaining about extends unknown which is useless bc that is the default of any generic
gustavoguichard
commented
May 3, 2024
| @@ -6,7 +6,7 @@ import type { | |||
| KeysOfStrings, | |||
| ObjectFromSchema, | |||
| } from './prelude' | |||
| import { objectFromSchema, mapObject, browser } from './prelude' | |||
| import { objectFromSchema, mapObject, browser, parseDate } from './prelude' | |||
There was a problem hiding this comment.
Another eslint rule to avoid multiple lines of imports from the same file
gustavoguichard
commented
May 3, 2024
| @@ -64,7 +64,7 @@ class Example { | |||
| } | |||
|
|
|||
| await expect(field.input).toHaveValue(value) | |||
| await expect(field.input).toHaveAttribute('type', type) | |||
| expect((await field.input.getAttribute('type')) ?? '').toBe(type) | |||
There was a problem hiding this comment.
There's an update in playwright that makes getAttribute('type') return null instead of '' so I had to add this change to make a bunch of tests pass after upgrading Playwright
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the first of some PRs that will update packages, especially in the examples folder to have more up to date examples.
Upgrading TS required us to upgrade TS eslint and thus the eslint itself. So I added prettier and playwright to the package of updates.