WIP - Add for rescue it is possible to add attributes that do not exist in the model #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diogob
reviewed
Dec 1, 2020
| @@ -23,14 +23,16 @@ def identifier | |||
| params[resource.identifier] | |||
| end | |||
|
|
|||
| def member_params | |||
| def member_params # rubocop:disable Metrics/AbcSize | |||
There was a problem hiding this comment.
how about we disable this for the project?
these ad-hoc rubocop disable reduce legibility and don't help with keeping the code standards (one of rubocop main purposes).
| params | ||
| .permit(resource.request_attributes.keys) | ||
| .merge( | ||
| params | ||
| .require(resource.resource_name) | ||
| .permit! | ||
| ) | ||
| rescue StandardError | ||
| params.permit(resource.request_attributes.keys) |
There was a problem hiding this comment.
We need a solution that prevents the error from happening instead of rescuing. Please give instructions on how to reproduce the issue and let's find another way to solve the problem in the current project that needs this.
There was a problem hiding this comment.
I created the Issue: #55.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.