feat(local): delay evaluate memtransfer instructions#166
Open
LinerSu wants to merge 1 commit intoseahorn:mainfrom
Open
feat(local): delay evaluate memtransfer instructions#166LinerSu wants to merge 1 commit intoseahorn:mainfrom
LinerSu wants to merge 1 commit intoseahorn:mainfrom
Conversation
lib/seadsa/DsaLocal.cc
Outdated
| m_dl.getTypeStoreSize( | ||
| I.getSource()->getType()->getPointerElementType()) == | ||
| m_dl.getTypeStoreSize( | ||
| I.getDest()->getType()->getPointerElementType())) { |
Collaborator
There was a problem hiding this comment.
Curious, will this logic (of getting size through pointer) work with LLVM 15 and above?
If no, is there an alternative so that porting becomes easier?
Author
There was a problem hiding this comment.
I don’t think so. I believe Kevin is working on a type inference algorithm to recover this information. Perhaps we can gain some insights from it.
Contributor
There was a problem hiding this comment.
This is to be refined. With lazy memcpy handling, we can rely on inferred sizes rather than types.
agurfinkel
reviewed
Oct 24, 2025
agurfinkel
reviewed
Oct 24, 2025
agurfinkel
reviewed
Oct 24, 2025
agurfinkel
reviewed
Oct 24, 2025
agurfinkel
approved these changes
Oct 24, 2025
Contributor
agurfinkel
left a comment
agurfinkel
left a comment
There was a problem hiding this comment.
Looks good. Left minor comments only
LinerSu
force-pushed
the
delay-memtransfer
branch
from
5ff4f71 to
a934732
Compare
For memcpy calls, we run local analysis first, then evaluate instructions. The transfer function avoids unifying cells for precision. Enable via option `--sea-dsa-delay-mem-transfer` and inline functions before use.
LinerSu
force-pushed
the
delay-memtransfer
branch
from
a934732 to
996cc54
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For memcpy calls, we run local analysis first, then evaluate instructions.
The transfer function avoids unifying cells for precision.
Enable via option
--sea-dsa-delay-mem-transferand inline functions before use.