Changes and fixes to run dev14 successfully CI
#156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We needed to modify slightly the expected graphs because the bitcode changed from LLVM 5.0 to LLVM 14.0. For LLVM 14, I just use clang -c -emit-llvm ... Unfortunately, I do not remember which flags we used for LLVM 5.0
We wrote the code ourselves that ensures a resolved call is type-compatible with the actual call. Since LLVM 14 (maybe some earlier version) we can use isLegalToPromote for that. This change was already committed in 156e5f1 in dev14-jn branch but it was not ported to dev14.
We need to strip bitcasts in order to resolve trivial indirect calls. We modified the code that strips bitcasts to catch all patterns from the test suite.
The right way to remove an edge in the call graph is by using the method removeCallEdge. Because this method takes as input an iterator we are forced to remove edges while iterating over them so we need to be careful. Before, we were using removeCallEdgeFor that takes as input a call instruction. However, once we start resolving an indirect call we can have multiple edges from the same node and with the same callsite attached to the edge. Calling removeCallEdgeFor removes one of the edges but it is not clear which one. Probably the code was working because it was removing the first one which was the indirect call. For context, I add here an explanation about how the complete call graph looks like. A LLVM CallGraph consists of edges between nodes of type CallGraphNode. For CallGraphNode n1 and n2, and CallBase CB, an edge in CallGraph is a triple (n1, CB, n2) A _complete_ (seadsa) callgraph is just another LLVM CallGraph. If there is an edge E=(n1, CB, n2) where CB is an indirect call and therefore n2 is the (unique) _external node_ then we remove E and add possibly multiple edges (n1,CB,n3) where n3 is the CallGraphNode of each possible callee function identified by seadsa.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dev14was never run in CI so some of the tests were broken.This PR passes all tests.
Changes:
DsaCompleteCompleteGraph.cc