Handle functions that do not return but contain unreacahble instructions #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This occurs, for example, if a function calls `exit`. In this case, we still mark cells with `mem.in` markers. However, we only mark cells with `mem.out` if they return (because an `unreachable` instruction implies the program has terminated).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempts to fix issue #138
This occurs, for example, if a function calls
exit. In this case, we still mark cells withmem.inmarkers. However, we only mark cells withmem.outif they return (because anunreachableinstruction implies the program has terminated).I'm not sure if this is 100% correct, so please let me know if not!