Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cva6: add missing chardev include for dev_defn #191

Merged
merged 1 commit into from
Mar 14, 2025

Conversation

midnightveil
Copy link
Contributor

This was previously giving a build warning regarding it only being defined within this file itself.

/util_libs/libplatsupport/src/mach/cva6/serial.c:12:28: warning: ‘struct dev_defndeclared inside parameter list will not be visible outside of this definition or declaration
   12 | int uart_init(const struct dev_defn *defn,
      |                            ^~~~~~~~

@lsf37
Copy link
Member

lsf37 commented Mar 7, 2025

Still need to wrap the commit message body at 72 to pass the Gitlint check, but otherwise looks fine to me.

@lsf37 lsf37 self-assigned this Mar 7, 2025
This was previously giving a build warning regarding it only being
defined within this file itself.

Signed-off-by: julia <[email protected]>
@midnightveil midnightveil force-pushed the cva6-missing-include branch from 3be0b41 to e039e06 Compare March 7, 2025 01:22
@lsf37 lsf37 merged commit 53cf4aa into seL4:master Mar 14, 2025
20 checks passed
@midnightveil midnightveil deleted the cva6-missing-include branch March 14, 2025 03:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants