Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented Privacy Metrics #55

Merged
merged 49 commits into from
Mar 24, 2021
Merged

Implemented Privacy Metrics #55

merged 49 commits into from
Mar 24, 2021

Conversation

fealho
Copy link
Member

@fealho fealho commented Mar 22, 2021

Resolves #36.

@fealho fealho requested review from csala and pvk-developer March 22, 2021 17:05
Copy link
Contributor

@csala csala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like the error from Github Actions happens because of the latest torch release. We could try capping it to "torch<1.8" on the workflow yaml file. Also see why here it fails but other projects do not.

Also: sdmetrics/single_table/README.md should be updated to add the new metrics.

@csala
Copy link
Contributor

csala commented Mar 24, 2021

I just re-triggered the last build that failed because of the GMLogLikelihood noisy output. I also opened issue #56 to work around this problem.

Copy link
Contributor

@csala csala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks great now!

@csala csala merged commit 65665e1 into master Mar 24, 2021
@csala csala deleted the privacy-metrics-test branch March 24, 2021 19:18
@csala csala mentioned this pull request Mar 24, 2021
@pvk-developer pvk-developer added this to the 0.3.0 milestone Mar 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement privacy metrics
4 participants