Add ruff for linting, remove flake8, remove isort, remove pylint #303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amontanez24
reviewed
May 28, 2024
There was a problem hiding this comment.
Why does the PR description say it closes this issue: sdv-dev/SDMetrics#268
|
@amontanez24 fixed |
amontanez24
reviewed
May 29, 2024
pyproject.toml
Outdated
| line-length = 100 | ||
| indent-width = 4 | ||
| src = ["sdgym"] | ||
| target-version = "py312" |
There was a problem hiding this comment.
The documentation says that this should be the minimum version. Should we change to 3.8?
There was a problem hiding this comment.
Good point. Given that ruff says to use requires-python, I just ended up removing it: bbdf138
If you're already using a pyproject.toml file, we recommend project.requires-python instead, as it's based on Python packaging standards, and will be respected by other tools.
amontanez24
approved these changes
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CU-86azg1jc5