http/client: Pass abort source by pointer #2650
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the client API suggest passing it by reference and for those, that don't want to abort requests there's 2nd set of calls that don't have abort source at all. Internally the reference is converted into a pointer, and the 2nd set of calls passes nullptr. At the same time users of this API (scylla S3 client) make the reverse "choice" -- it passes abort source by pointer all the way down to http client and then decides which API to call, with abort source reference or without it. Fix this mess by making client accept abort source by pointer. Signed-off-by: Pavel Emelyanov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the client API suggest passing it by reference and for those, that don't want to abort requests there's 2nd set of calls that don't have abort source at all. Internally the reference is converted into a pointer, and the 2nd set of calls passes nullptr.
At the same time users of this API (scylla S3 client) make the reverse "choice" -- it passes abort source by pointer all the way down to http client and then decides which API to call, with abort source reference or without it.
Fix this mess by making client accept abort source by pointer.