table: Directly compare std::optional<shard_id> with shard_id

[xemul]

There's a loop that calculates the number of shard matches over a tablet map. The check of the given shard against optional can be made shorter.

[scylladb-promoter]

🔴 CI State: FAILURE

✅ - Build
✅ - Container Test
✅ - dtest with topology changes
✅ - dtest
❌ - Unit Tests

Failed Tests (2/30664):

• test_service_levels_work_during_recovery 🔍
• auth_cluster.test_raft_service_levels.debug.2 🔍

Build Details:

• Duration: 3 hr 11 min
• Builder: spider5.cloudius-systems.com

[scylladb-promoter]

🟢 CI State: SUCCESS

✅ - Build
✅ - Container Test
✅ - dtest
✅ - dtest with topology changes
✅ - Unit Tests

Build Details:

• Duration: 2 hr 58 min
• Builder: spider8.cloudius-systems.com

[xemul]

🔴 CI State: FAILURE

✅ - Build ✅ - Container Test ✅ - dtest with topology changes ✅ - dtest ❌ - Unit Tests

Failed Tests (2/30664):

* [test_service_levels_work_during_recovery](https://jenkins.scylladb.com//job/scylla-master/job/scylla-ci/8679/testReport/junit/%28root%29/test_raft_service_levels/Tests___Unit_Tests___test_service_levels_work_during_recovery) [🔍](https://github.com/scylladb/scylladb/issues?q=is:issue+is:open+test_service_levels_work_during_recovery)

* [auth_cluster.test_raft_service_levels.debug.2](https://jenkins.scylladb.com//job/scylla-master/job/scylla-ci/8679/testReport/junit/%28root%29/non-boost%20tests/Tests___Unit_Tests___auth_cluster_test_raft_service_levels_debug_2) [🔍](https://github.com/scylladb/scylladb/issues?q=is:issue+is:open+auth_cluster.test_raft_service_levels.debug.2)

Build Details:

* Duration: 3 hr 11 min

* Builder: spider5.cloudius-systems.com

Looks like instance died, the re-run was automatic. Will kick once more

[xemul]

clang-tidy fails with

/usr/local/bin/cmake -E __run_co_compile --tidy="clang-tidy-18;--checks=-*,bugprone-use-after-move;--extra-arg-before=--driver-mode=g++" --source=/home/runner/work/scylladb/scylladb/thrift/controller.cc -- /usr/bin/clang++-18 -DBOOST_NO_CXX98_FUNCTION_BASE -DSCYLLA_BUILD_MODE=release -DSEASTAR_API_LEVEL=7 -DSEASTAR_LOGGER_COMPILE_TIME_FMT -DSEASTAR_LOGGER_TYPE_STDOUT -DSEASTAR_SCHEDULING_GROUPS_COUNT=16 -DSEASTAR_SSTRING -DXXH_PRIVATE_API -I/home/runner/work/scylladb/scylladb -I/home/runner/work/scylladb/scylladb/seastar/include -I/home/runner/work/scylladb/scylladb/build/seastar/gen/include -I/home/runner/work/scylladb/scylladb/build/seastar/gen/src -I/home/runner/work/scylladb/scylladb/build/gen -isystem /home/runner/work/scylladb/scylladb/cooking/include -DFMT_HEADER_ONLY -ffunction-sections -fdata-sections -O3 -g -gz -std=gnu++20 -fvisibility=hidden -Wall -Werror -Wextra -Wno-error=deprecated-declarations -Wimplicit-fallthrough -Wno-c++11-narrowing -Wno-deprecated-copy -Wno-mismatched-tags -Wno-missing-field-initializers -Wno-overloaded-virtual -Wno-unsupported-friend -Wno-enum-constexpr-conversion -Wno-unused-parameter -ffile-prefix-map=/home/runner/work/scylladb/scylladb=. -march=westmere -mllvm -inline-threshold=2500 -fno-slp-vectorize -U_FORTIFY_SOURCE -Werror=unused-result -MD -MT thrift/CMakeFiles/thrift.dir/controller.cc.o -MF thrift/CMakeFiles/thrift.dir/controller.cc.o.d -o thrift/CMakeFiles/thrift.dir/controller.cc.o -c /home/runner/work/scylladb/scylladb/thrift/controller.cc
Error: /home/runner/work/scylladb/scylladb/serializer_impl.hh:20:10: error: 'absl/container/btree_set.h' file not found [clang-diagnostic-error]
   20 | #include <absl/container/btree_set.h>
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~

which looks like job misconfiguration (@benipeled ☝️ )

[scylladb-promoter]

🟢 CI State: SUCCESS

✅ - Build
✅ - Container Test
✅ - dtest with topology changes
✅ - dtest
✅ - Unit Tests

Build Details:

• Duration: 4 hr 43 min
• Builder: i-03f6926df73fb94cb (m5ad.12xlarge)