[Backport 5.4] alternator: fix REST API access to an Alternator LSI #18589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
The API req->param["name"] to access parameters in the path part of the URL was buggy - it forgot to do URL decoding and the result of our use of it in Scylla was bugs like #5883 - where special characters in certain REST API requests got botched up (encoded by the client, then not decoded by the server). The solution is to replace all uses of req->param["name"] by the new req->get_path_param("name"), which does the decoding correctly. Unfortunately we needed to change 104 (!) callers in this patch, but the transformation is mostly mechanical and there is no functional changes in this patch. Another set of changes was to bring req, not req->param, to a few functions that want to get the path param. This patch avoids the numerous deprecation warnings we had before, and more importantly, it fixes #5883. Signed-off-by: Nadav Har'El <[email protected]> (cherry picked from commit 1aacfdf) # Conflicts: # api/messaging_service.cc # api/storage_service.cc # api/storage_service.hh # api/task_manager.cc # api/task_manager_test.cc # api/tasks.cc # api/token_metadata.cc
The name of the Scylla table backing an Alternator LSI looks like basename:!lsiname. Some REST API clients (including Scylla Manager) when they send a "!" character in the REST API request may decide to "URL encode" it - convert it to %21. Because of a Seastar bug (scylladb/seastar#725) Scylla's REST API server forgets to do the URL decoding, which leads to the REST API request failing to address the LSI table. This patch introduces a test for this bug, which fails without the Seastar issue being fixed, and passes afterwards (i.e., after the previous patch that starts to use the new, fixed, Seastar API). The test creates an LSI, uses the REST API to find its name and then tries to call some REST API ("compaction_strategy") on this table name, after deliberately URL-encoding it. Refs #5883. Signed-off-by: Nadav Har'El <[email protected]> (cherry picked from commit 5558143)
|
Cherry-pick of 1aacfdf has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The name of the Scylla table backing an Alternator LSI looks like
basename:!lsiname. Some REST API clients (including Scylla Manager) when they send a "!" character in the REST API request path may decide to "URL encode" it - convert it to%21.Because of a Seastar bug (scylladb/seastar#725) Scylla's REST API server forgets to do the URL decoding on the path part of the request, which leads to the REST API request failing to address the LSI table.
The first patch in this PR fixes the bug by using a new Seastar API introduced in scylladb/seastar#2125 that does the URL decoding as appropriate. The second patch in the PR is a new test for this bug, which fails without the fix, and passes afterwards.
Fixes #5883.
(cherry picked from commit 1aacfdf)
(cherry picked from commit 5558143)
Refs #18286