Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(DataCenterTopologyRfControl): stop taking region to RF=0 #10153

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(DataCenterTopologyRfControl): stop taking region to RF=0 #10153

wants to merge 1 commit into from
+28 −28

Conversation

fruch
Copy link
Contributor

@fruch fruch commented Feb 20, 2025 •
edited
Loading

code in _alter_keyspace_rf was reffering only to one DC in the ALTER command, that lead to RF=0 on other DCs

this complication the situation for scylla, and surface multiple bug in operation that are talking place during this operation also is kind of change is not the intended behavier of this code

so now it would update the DC RF as needed, while leaving the other DCs RF the same as they were

Fix: #10136

Testing

  • [ ]

PR pre-checks (self review)

  • I added the relevant backport labels
  • I didn't leave commented-out/debugging code

Reminders

  • Add New configuration option and document them (in sdcm/sct_config.py)
  • Add unit tests to cover my changes (under unit-test/ folder)
  • Update the Readme/doc folder relevant to this change (if needed)

@fruch
fix(DataCenterTopologyRfControl): stop taking region to RF=0
137a47c 
code in `_alter_keyspace_rf` was reffering only to one DC
in the ALTER command, that lead to RF=0 on other DCs

this complication the situation for scylla, and surface multiple
bug in operation that are talking place during this operation
also is kind of change is not the intended behavier of this code

so now it would update the DC RF as needed, while leaving the other
DCs RF the same as they were

Fix: scylladb#10136
@fruch fruch requested review from yarongilor and soyacz February 20, 2025 15:49
yarongilor
yarongilor approved these changes Feb 20, 2025
View reviewed changes
Copy link
Contributor

@yarongilor yarongilor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
did it pass ok?
why backporting only to 2025.1?

soyacz
soyacz approved these changes Feb 21, 2025
View reviewed changes
Copy link
Contributor

@soyacz soyacz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yarongilor yarongilor yarongilor approved these changes

@soyacz soyacz soyacz approved these changes

Assignees

@fruch fruch

Labels
backport/2025.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DataCenterTopologyRfControl doesn't work as expect in case of multi-dc
3 participants
@fruch @yarongilor @soyacz