Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2025.1] improvement(tomstone-gc): Added a verification to large-partitions tests #10092

Draft
wants to merge 5 commits into
base: branch-2025.1
Choose a base branch
from

Conversation

scylladbbot
Copy link

Assuming some deletion nemeses ran on these tests,
The tomstone-gc-verification thread can validate its deletion.

PR pre-checks (self review)

  • I followed KISS principle and best practices

  • I didn't leave commented-out/debugging code

  • I added the relevant backport labels

  • New configuration option are added and documented (in sdcm/sct_config.py)

  • I have added tests to cover my changes (Infrastructure only - under unit-test/ folder)

  • All new and existing unit tests passed (CI)

  • I have updated the Readme/doc folder accordingly (if needed)

  • (cherry picked from commit 85f6c6e)

  • (cherry picked from commit bdcbf7b)

  • (cherry picked from commit a0cb3eb)

  • (cherry picked from commit bdcbf7b)

  • (cherry picked from commit a0cb3eb)

Parent PR: #5737

@scylladbbot
Copy link
Author

@yarongilor - This PR has conflicts, therefore it was moved to draft
Please resolve them and mark this PR as ready for review

@scylladbbot scylladbbot force-pushed the backport/5737/to-2025.1 branch from 4939897 to 5e3889c Compare February 17, 2025 12:43
yarongilor added 5 commits February 17, 2025 12:43
Assuming some deletion nemeses ran on these tests,
The tomstone-gc-verification thread can validate its deletion.

(cherry picked from commit 85f6c6e)
…of "scylla sstable dump-data"

following the new output format of "scylla sstable dump-data",
it is now updated in functions of get_compacted_tombstone_deletion_info and get_tombstone_date.

(cherry picked from commit bdcbf7b)
…of "scylla sstable dump-data"

following the new output format of "scylla sstable dump-data",
it is now updated in functions of get_compacted_tombstone_deletion_info and get_tombstone_date.

(cherry picked from commit a0cb3eb)
…of "scylla sstable dump-data"

following the new output format of "scylla sstable dump-data",
it is now updated in functions of get_compacted_tombstone_deletion_info and get_tombstone_date.

(cherry picked from commit bdcbf7b)
…of "scylla sstable dump-data"

following the new output format of "scylla sstable dump-data",
it is now updated in functions of get_compacted_tombstone_deletion_info and get_tombstone_date.

(cherry picked from commit a0cb3eb)
@scylladbbot scylladbbot force-pushed the backport/5737/to-2025.1 branch from 5e3889c to f95eac0 Compare February 17, 2025 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants