Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adopt the Scientific Python deprecation schedule: #3485

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

flying-sheep
Copy link
Member

@flying-sheep flying-sheep commented Feb 25, 2025

  • Release notes not necessary because:

Change supported Python versions to 3.11–3.13

See scverse/anndata#1768

The rest flowed from there:

  • h5py 3.7 failed to compile, so 3.8 it is
  • only numba>=0.58 support the new numpy min version
  • the lowest scikit-image version that has wheels for Python 3.11 depends on networkx>=0.28
  • Update rename_categories internals anndata#790 is only available in anndata 0.9 (I wonder how the minimum versions job passed before with anndata 0.8!)

Change supported Python versions to 3.11–3.13
@flying-sheep flying-sheep marked this pull request as ready for review February 25, 2025 15:50
@flying-sheep flying-sheep added this to the 1.12.0 milestone Feb 25, 2025
Copy link

codecov bot commented Feb 27, 2025

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 75.52%. Comparing base (6e68d06) to head (63990be).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
src/scanpy/readwrite.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3485      +/-   ##
==========================================
- Coverage   75.53%   75.52%   -0.02%     
==========================================
  Files         113      113              
  Lines       13252    13229      -23     
==========================================
- Hits        10010     9991      -19     
+ Misses       3242     3238       -4     
Files with missing lines Coverage Δ
src/scanpy/_compat.py 85.84% <ø> (+1.35%) ⬆️
src/scanpy/logging.py 97.39% <100.00%> (ø)
src/scanpy/readwrite.py 74.70% <50.00%> (ø)

... and 1 file with indirect coverage changes

@flying-sheep flying-sheep requested review from ilan-gold and removed request for ilan-gold February 27, 2025 18:26
@@ -0,0 +1 @@
Adopt the Scientific Python [deprecation schedule](https://scientific-python.org/specs/spec-0000/): remove Python 3.10 support and add Python 3.13 support {smaller}`P Angerer`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add that this includes bumping minimum anndata support as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Follow Scientific Python deprecation schedule
2 participants