(fix): make basic-analysis runnable
#81
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
flying-sheep
approved these changes
Jan 23, 2024
Member
flying-sheep
left a comment
flying-sheep
left a comment
There was a problem hiding this comment.
Very nice!
Like with the other one, I think distplot→histplot/displot would be something to do if we didn’t encourage people to use SquidPy anyway.
Also we should probably look into
No data for colormapping provided via 'c'. Parameters 'cmap' will be ignored
That shouldn’t happen
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #79, things need to actually be runable somewhere and this starts that process. I'm not sure what to do about the merfish at the bottom since it requires PNAS links that don't work. We may have to store the data in the repo, which might be doable since it is not that big.