Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate positional boolean arguments #1694

Merged
merged 16 commits into from
Jan 7, 2025

Merge branch 'main' into no-positional-bools

298fd0c
Select commit
Loading
Failed to load commit list.
Merged

Deprecate positional boolean arguments #1694

Merge branch 'main' into no-positional-bools
298fd0c
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 7, 2025 in 1s

84.20% (target 80.00%)

View this Pull Request on Codecov

84.20% (target 80.00%)

Details

Codecov Report

Attention: Patch coverage is 90.81633% with 9 lines in your changes missing coverage. Please review.

Project coverage is 84.20%. Comparing base (4bcd989) to head (298fd0c).

Files with missing lines Patch % Lines
src/anndata/tests/helpers.py 88.23% 4 Missing ⚠️
src/anndata/compat/__init__.py 66.66% 2 Missing ⚠️
...anndata/experimental/multi_files/_anncollection.py 90.00% 1 Missing ⚠️
src/anndata/experimental/pytorch/_annloader.py 90.00% 1 Missing ⚠️
src/anndata/logging.py 87.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1694      +/-   ##
==========================================
- Coverage   87.08%   84.20%   -2.88%     
==========================================
  Files          40       40              
  Lines        6107     6135      +28     
==========================================
- Hits         5318     5166     -152     
- Misses        789      969     +180     
Files with missing lines Coverage Δ
src/anndata/_core/anndata.py 83.58% <100.00%> (-0.15%) ⬇️
src/anndata/_core/file_backing.py 91.07% <100.00%> (ø)
src/anndata/_core/merge.py 83.39% <100.00%> (-11.65%) ⬇️
src/anndata/_io/specs/methods.py 88.18% <100.00%> (-0.43%) ⬇️
src/anndata/_io/write.py 77.52% <100.00%> (+0.78%) ⬆️
src/anndata/utils.py 84.72% <ø> (-0.93%) ⬇️
...anndata/experimental/multi_files/_anncollection.py 70.91% <90.00%> (+0.23%) ⬆️
src/anndata/experimental/pytorch/_annloader.py 23.52% <90.00%> (+3.12%) ⬆️
src/anndata/logging.py 50.00% <87.50%> (+4.83%) ⬆️
src/anndata/compat/__init__.py 79.91% <66.66%> (-5.44%) ⬇️
... and 1 more

... and 7 files with indirect coverage changes