Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Untagged #1

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Untagged #1

wants to merge 4 commits into from

Conversation

michield
Copy link

@michield michield commented Feb 8, 2011

Hi, thanks for the great tool. I installed it on my local machine, to deal with the amazing mess of bookmarks I had in FF.

However, after importing my FF bookmarks, I ended up with a large amount of bookmarks that were all without tags. So I decided to make an "untagged" function that lists all bookmarks that have no tags assigned, so that you can easily work your way through them and tag them all.

It's working nicely on my machine. Feel free to pull it in to the main.

Cheers

Michiel

(btw still a bit new to git and github, so I hope I did it all ok)

@michield
Copy link
Author

michield commented Feb 9, 2011

the 2nd change fixes the problem when a tag has & in it. I have a tag "Q&A" which was converted into q&a on subsequent uses

@scronide
Copy link
Owner

Thanks Michiel. I realise this is no longer documented, so fairly obscure, but Scuttle already tracks untagged bookmarks under a hidden system tag: system:unfiled. This is handled in the attachTags() function in the TagService.

Although hidden, you should be able to access this tag just like any others: tags.php/system:unfiled

@michield
Copy link
Author

Ah, well, actually I did notice that when looking in the DB, and so I use that to list the "untagged" URLs. I simply do a "where tag like "system:%". My change gives it a more obvious place to work on it. But sure, if you feel it's not that useful, no problem. For me it really scratched an itch :-) But I guess once I've worked my way through my 100 pages of untagged URLs, it's use will become limited.

By the way, my second bugfix wasn't rendered properly here. I meant that Q&A turned into Q& amp;A. One of those annoying HTML things.

@michield
Copy link
Author

I've added the jQuery UI autocomplete http://jqueryui.com/demos/autocomplete/#multiple to the "tags" field when editing a bookmark. Quite useful when you know your tags, but can't find them in the list of popular tags.

@makoshark
Copy link

Too bad that the auto-complete work was buried here in this unrelated pull request. I didn't see it here, although I agree it's useful.

I refactored work in this repository and I just made a pull request here. Having just looked at this code briefly, I think I the patch I've requested more.

Either way, this pull request should probably be closed (given that the functionality it adds primarily is already dealt with). Autocomplete should be dealt with separately -- either the relevant commits should be treated as a new/separate pull request and we should figure what combination of the two approaches should be used primarily.

It's great to see such a great community of Scuttle users sharing their stuff here!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants