-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[UI] View badges mint status on Discover badges page #1280
Open
Udassi-Pawan
wants to merge
676
commits into
scroll-tech:sepolia
Choose a base branch
from
Udassi-Pawan:sepolia
base: sepolia
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
canvas: clean code
* Update withdraw copy * Update withdraw copy
fix: only support link
* Add community page * Fix search params * Adjust mobile style * Update link * Fix label * Adjust style * Adjust styles * Add og image * Adjust camera position * Adjust style
* Update config
fix: allow new tab
Signed-off-by: yqrashawn <[email protected]>
Fix: Use BigInt for handling large numbers to avoid scientific notation.
doc: add canvas doc
fix: ecosystem metrics
@Udassi-Pawan is attempting to deploy a commit to the Scroll Team on Vercel. A member of the Team first needs to authorize it. |
This is my first contribution to Scroll, |
Udassi-Pawan
changed the title
[UX] View badges mint status on Discover badges page
[UI] View badges mint status on Discover badges page
Sep 18, 2024
Hey @Holybasil , |
Holybasil
force-pushed
the
sepolia
branch
2 times, most recently
from
December 26, 2024 01:41
5975871
to
b86453d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Enhance Badge Visibility with Green Border
Checklist
/docs
Description
Description: This PR addresses an issue on the badge discovery page (https://scroll.io/canvas-and-badges#discover) where it was challenging to distinguish between badges that are minted and those that are not.
Changes Made:
Minted Badges: Added a green border to badges that have already been minted. This visually distinguishes them from unminted badges.
These visual cues improve user experience by clearly indicating the status of each badge.