Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Korean internationalization #71

Conversation

KesharwaniArpita
Copy link
Contributor

Description

This PR adds a ko.json file to the Scribe-i18n/jsons directory, with a few localizations of some strings found in Scribe-i18n/jsons/en-US.json.

Related Issue

#53

Copy link

Thank you for the pull request!

The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and i18n rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you!

@andrewtavis
Copy link
Member

@KesharwaniArpita: Do you speak Korean? I'd also like to note that #53 was assigned to a different person.

@KesharwaniArpita
Copy link
Contributor Author

Hi! @andrewtavis I am really sorry I didn't notice it was assigned to someone. I should have been more careful. I'll delete the pull request.
(I used google translate to do the translation and then manually translated the left english phrases and got it proof read from a friend studying Korean at my research lab.)
Again sorry for the confusion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants