Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve android convert str to json #66

Merged

Conversation

OmarAI2003
Copy link
Contributor

@OmarAI2003 OmarAI2003 commented Oct 9, 2024

Final pr related to the Improvments disscused here here to the localization of JSON files this PR includes the following changes :

Key Changes:

  • Added try-except blocks for handling FileNotFoundError, PermissionError, and general exceptions during file reading and writing.
  • Improved error messages for clearer feedback.

Related issue:
#57

- Added 	ry-except blocks to handle FileNotFoundError, PermissionError, and general exceptions for w/r operations.
Copy link

github-actions bot commented Oct 9, 2024

Thank you for the pull request!

The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and i18n rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you!

Maintainer checklist

  • The commit messages for the remote branch should be checked to make sure the contributor's email is set up correctly so that they receive credit for their contribution
    • The contributor's name and icon in remote commits should be the same as what appears in the PR
    • If there's a mismatch, the contributor needs to make sure that the email they use for GitHub matches what they have for git config user.email in their local activist repo

@andrewtavis andrewtavis added the hacktoberfest-accepted Accepted as a part of Hacktoberfest label Oct 9, 2024
Copy link
Member

@andrewtavis andrewtavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As Scribe-i18n is an internal tool, @OmarAI2003, I don't think we need to add in the permissions error as anyone who'd be using this would be an org member :) Aside from removing that it was just some spacing 😊

Thanks so much for your hard work here! So great to have all of these scripts updated now 😊

@andrewtavis andrewtavis merged commit 45bce87 into scribe-org:main Oct 9, 2024
@OmarAI2003 OmarAI2003 deleted the improve-android-convert-str-to-json branch October 9, 2024 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted Accepted as a part of Hacktoberfest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants