Expand and Refactor Latin Verb Query to Focus on Present Tense Forms #495
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributor checklist
pytest
command as directed in the testing section of the contributing guideDescription
This PR expands and refactors the existing SPARQL query to focus solely on Present Tense verb forms(till now) for Latin (Q397) verbs. The changes made include:
VALUES
block.OPTIONAL
blocks to align with this restriction, ensuring they cover Subjunctive, Imperative, and Indicative for different persons (First, Second, Third; Singular and Plural).Testing:
Future Work:
Past Tense: A similar refactor can be done to retrieve past tense verb forms(available on wikidata). These can be added using a
VALUES
block that filters for relevant grammatical features such as:Future Tense: The query can be extended to retrieve future tense forms by adding future-specific grammatical features:
Both Past and Future tense forms can follow the same pattern as this Present Tense query, with additional
VALUES
blocks or separate queries focused on those tenses.Impact:
The refactor improves the clarity and performance of the current query by focusing on a single tense while maintaining flexibility for future enhancements to cover other tenses.
Related issue