feat(queries): Extend SPARQL query to extract additional Latin verb forms (issue #444) #479
Conversation
- Enhanced noun query to include definite and indefinite forms - Updated proper noun query with definite and vocative forms - Expanded verb query to cover past simple, present continuous, future tense, and imperative forms - Added comments and FILTER options for both Latin and Arabic script variants - Improved overall query structure and readability
This commit integrates the autosuggestions functionality from process_wiki.py into the get_data function in get.py. Key changes include: 1. Import gen_autosuggestions function from scribe_data.wikipedia.process_wiki 2. Add new conditional block to handle 'autosuggestions' data type 3. Implement autosuggestions generation logic for specified languages 4. Add placeholder load_text_corpus function for future implementation The autosuggestions block now: - Iterates through specified languages - Loads text corpus (placeholder function to be implemented) - Calls gen_autosuggestions with appropriate parameters - Sets update_local_data=True to save results - Uses interactive mode for verbose output This update allows CLI users to generate autosuggestions directly via the get command, streamlining the data generation process. Note: The load_text_corpus function needs to be implemented to load the actual text corpus for each language before this feature is fully functional. TODO: - Implement load_text_corpus function - Ensure correct file paths and imports across the project - Add error handling for corpus loading and autosuggestions generation - Update documentation to reflect new autosuggestions functionality in CLI
…orms - Add support for extracting present, future, past imperfect, perfect, and pluperfect forms - Include grammatical features (mood, person, number) for each tense - Implement OPTIONAL matching to handle incomplete conjugation data - Add proper PREFIX declarations for all used namespaces - Improve query organization and readability with comments - Add ORDER BY clause and reasonable LIMIT for better results handling Resolves scribe-org#444
Thank you for the pull request!The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :) If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Data rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you! Maintainer checklist |
|
Hello @KesharwaniArpita 👋🏼, |
|
@Collins-Webdev What are the conflicts? |
|
If its about the emoji files: Delete them from you repo |
|
You can also bring down the current version of main and start from there again. Might be easier :) |
|
There are a lot of other files in this PR than the Latin verbs one, @Collins-Webdev, so I'm going to close this. I'll write in the issue to describe what should happen next. |
Contributor checklist
pytestcommand as directed in the testing section of the contributing guideResolves #444