Main

[Nowshin1077]

Contributor checklist

• This pull request is on a separate branch and not the main branch

---

Description

Related issue

• Expand Bengali data queries #302

[github-actions]

Thank you for the pull request!

The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Data rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you!

Maintainer checklist

• The commit messages for the remote branch should be checked to make sure the contributor's email is set up correctly so that they receive credit for their contribution

  • The contributor's name and icon in remote commits should be the same as what appears in the PR
  • If there's a mismatch, the contributor needs to make sure that the email they use for GitHub matches what they have for git config user.email in their local Scribe-Data repo

• The linting and formatting workflow within the PR checks do not indicate new errors in the files changed

• The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

[andrewtavis]

What do you want to do here, @Nowshin1077? I'm not even really sure if the Bengali adverbs query needs to be expanded 🤔 We could do a minor edit in here though?

[andrewtavis]

Really no stress about the merge conflict :)

[andrewtavis]

I was actually right in the middle of fixing it 😊

[Nowshin1077]

Sorry, I noticed after making a PR that you already added "Adverbs" query 😬, we can do some minor edits though for other queries. Could you please give me some suggestions if possible? I don't know, I am just feeling lost as I am a noob 😬

[andrewtavis]

Let me fix the merge conflict and then we can merge this in with a minor edit I've thought of 😊

[andrewtavis]

I was thinking when looking at it that adding in Bangla would make sense so it's easier for people to find the queries in the codebase if they're searching for this name of the language. Would you have interest in looking into #236? I can also help you find another!

[andrewtavis]

A few more tips, @Nowshin1077:

• Don't name your branch Main
  • Include the issue number you're working on, so 302-bengali-adverbs
• Also make a branch for your work so that the any changes that are needed are not committed directly to the main of your fork :)

[andrewtavis]

Or how does Greek sound? I could make an issue for that for you? :)

[andrewtavis]

I.e. adding the language queries for Greek 😊

[Nowshin1077]

Thanks fo the tips! I will keep that on my mind. And yeah Bangla would make more sense. 😊

Let me look into #236 for now then I can move to queries for Greek.
What do you say?

[andrewtavis]

Sounds perfect :)

[andrewtavis]

Feel free to write in there and ask for adverbs and adjectives to get started for simple queries, and then we can move to something more difficult 😊