-
Notifications
You must be signed in to change notification settings - Fork 880
feat: Fixing punctuation and grammar. #9358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
Added punctuation to the end of messages.
All contributors have signed the CLA ✍️ ✅ |
I have read the CLA Document and I hereby sign the CLA |
Request is ready for review! |
I think that is intentional. |
If you look into the l10n.json file for the messages, you can notice some (not all) have punctuation. Also, another note, I think it was ur request to fix “youtube” to YouTube lol |
indeed |
As per forum naming, “thread” is now “topic”
Changed “thread” to “topic” in messages |
Only those with more than one sentence have punctuation at the end. |
That would make sense, but it’d probably make more sense if they all had punctuation… |
Resolves:
* changed forum “thread” to “topic” as per forum namings
Changes:
Adds punctuation to many messages.
Ex: (new changes in bold)
{profileLink} favorited your project {projectLink}.
Test Coverage:
None should be needed.