Skip to content

feat: Fixing punctuation and grammar. #9358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

DDCcarr1
Copy link

@DDCcarr1 DDCcarr1 commented Mar 27, 2025

Resolves:

  • Messages not having punctuation on some.
    * changed forum “thread” to “topic” as per forum namings
  • Ideas “Youtube” to “YouTube”

Changes:

Adds punctuation to many messages.

Ex: (new changes in bold)
{profileLink} favorited your project {projectLink}.

Test Coverage:

None should be needed.

Added punctuation to the end of messages.
Copy link

github-actions bot commented Mar 27, 2025

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@DDCcarr1
Copy link
Author

I have read the CLA Document and I hereby sign the CLA

@DDCcarr1 DDCcarr1 marked this pull request as ready for review March 28, 2025 16:59
@DDCcarr1
Copy link
Author

Request is ready for review!

@alctd
Copy link

alctd commented Mar 29, 2025

Messages not having punctuation.

I think that is intentional.
Notice how many other websites don't have punctuation in the messages. The only one I can think of that doesn't is any MediaWiki wiki

@DDCcarr1
Copy link
Author

DDCcarr1 commented Mar 29, 2025

I think that is intentional. Notice how many other websites don't have punctuation in the messages. The only one I can think of that doesn't is any MediaWiki wiki

If you look into the l10n.json file for the messages, you can notice some (not all) have punctuation.

Also, another note, I think it was ur request to fix “youtube” to YouTube lol

@alctd
Copy link

alctd commented Mar 29, 2025

Also, another note, I think it was ur request to fix “youtube” to YouTube lol

indeed

As per forum naming, “thread” is now “topic”
@DDCcarr1
Copy link
Author

Changed “thread” to “topic” in messages

@mxmou
Copy link
Contributor

mxmou commented Mar 31, 2025

I think that is intentional. Notice how many other websites don't have punctuation in the messages. The only one I can think of that doesn't is any MediaWiki wiki

If you look into the l10n.json file for the messages, you can notice some (not all) have punctuation.

Only those with more than one sentence have punctuation at the end.

@DDCcarr1
Copy link
Author

I think that is intentional. Notice how many other websites don't have punctuation in the messages. The only one I can think of that doesn't is any MediaWiki wiki

If you look into the l10n.json file for the messages, you can notice some (not all) have punctuation.

Only those with more than one sentence have punctuation at the end.

That would make sense, but it’d probably make more sense if they all had punctuation…

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants