Closes #6343. Make certain args of ScrapyAgent and TunnelingAgent required #6349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kumar-sanchay
changed the title
|
The asserts are no longer needed. |
Done |
|
The asserts were there for typing purposes, to show that the args can't be None normally. If None is passed there will be a normal TypeError or something like that. |
|
@Gallaecio @wRAR let me know if anything got missed here :) |
|
As I said in the issue this is technically backwards-incompatible but only breaks the code that calls the constructors with all these args without using their names, which is unlikely (I took a quick look at the GH code search and didn't find such code). |
wRAR
approved these changes
May 10, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6343