Merge pull request openshift#134 from liggitt/error-logging

add detail to internal error messages
scramblesuit · Sep 24, 2016 · 839b9f1 · 839b9f1
2 parents f3e27ff + 813fe40
commit 839b9f1
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/access.go b/access.go
@@ -232,7 +232,7 @@ func (s *Server) handleAuthorizationCodeRequest(w *Response, r *http.Request) *A
 		// https://tools.ietf.org/html/rfc7636#section-4.1
 		if matched := pkceMatcher.MatchString(ret.CodeVerifier); !matched {
 			w.SetError(E_INVALID_REQUEST, "code_verifier invalid (rfc7636)")
-			w.InternalError = errors.New("invalid format")
+			w.InternalError = errors.New("code_verifier has invalid format")
 			return nil
 		}
 
@@ -250,7 +250,7 @@ func (s *Server) handleAuthorizationCodeRequest(w *Response, r *http.Request) *A
 		}
 		if codeVerifier != ret.AuthorizeData.CodeChallenge {
 			w.SetError(E_INVALID_GRANT, "code_verifier invalid (rfc7636)")
-			w.InternalError = errors.New("failed comparison with code_challenge")
+			w.InternalError = errors.New("code_verifier failed comparison with code_challenge")
 			return nil
 		}
 	}