Skip to content

Commit

Permalink
Consolidate composite hashes.
Browse files Browse the repository at this point in the history
  • Loading branch information
andybalholm committed Mar 9, 2019
1 parent ba67d8c commit 99596c6
Show file tree
Hide file tree
Showing 4 changed files with 23 additions and 226 deletions.
102 changes: 0 additions & 102 deletions h55.go

This file was deleted.

102 changes: 0 additions & 102 deletions h65.go

This file was deleted.

15 changes: 12 additions & 3 deletions hash.go
Original file line number Diff line number Diff line change
Expand Up @@ -286,7 +286,10 @@ func newHasher(typ int) HasherHandle {
case 10:
return new(H10)
case 35:
return new(H35)
return &hashComposite{
ha: newHasher(3),
hb: &hashRolling{jump: 4},
}
case 40:
return &hashForgetfulChain{
bucketBits: 15,
Expand Down Expand Up @@ -316,9 +319,15 @@ func newHasher(typ int) HasherHandle {
useDictionary: false,
}
case 55:
return new(H55)
return &hashComposite{
ha: newHasher(54),
hb: &hashRolling{jump: 4},
}
case 65:
return new(H65)
return &hashComposite{
ha: newHasher(6),
hb: &hashRolling{jump: 1},
}
}

panic(fmt.Sprintf("unknown hasher type: %d", typ))
Expand Down
30 changes: 11 additions & 19 deletions h35.go → hash_composite.go
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ package brotli

/* Composite hasher: This hasher allows to combine two other hashers, HASHER_A
and HASHER_B. */
func (h *H35) HashTypeLength() uint {
func (h *hashComposite) HashTypeLength() uint {
var a uint = h.ha.HashTypeLength()
var b uint = h.hb.HashTypeLength()
if a > b {
Expand All @@ -21,7 +21,7 @@ func (h *H35) HashTypeLength() uint {
}
}

func (h *H35) StoreLookahead() uint {
func (h *hashComposite) StoreLookahead() uint {
var a uint = h.ha.StoreLookahead()
var b uint = h.hb.StoreLookahead()
if a > b {
Expand All @@ -31,41 +31,33 @@ func (h *H35) StoreLookahead() uint {
}
}

type H35 struct {
type hashComposite struct {
HasherCommon
ha HasherHandle
hb HasherHandle
params *BrotliEncoderParams
}

func SelfH35(handle HasherHandle) *H35 {
return handle.(*H35)
}

func (h *H35) Initialize(params *BrotliEncoderParams) {
h.ha = nil
h.hb = nil
func (h *hashComposite) Initialize(params *BrotliEncoderParams) {
h.params = params
}

/* TODO: Initialize of the hashers is defered to Prepare (and params
remembered here) because we don't get the one_shot and input_size params
here that are needed to know the memory size of them. Instead provide
those params to all hashers InitializeH35 */
func (h *H35) Prepare(one_shot bool, input_size uint, data []byte) {
those params to all hashers InitializehashComposite */
func (h *hashComposite) Prepare(one_shot bool, input_size uint, data []byte) {
if h.ha == nil {
var common_a *HasherCommon
var common_b *HasherCommon

h.ha = newHasher(3)
common_a = h.ha.Common()
common_a.params = h.params.hasher
common_a.is_prepared_ = false
common_a.dict_num_lookups = 0
common_a.dict_num_matches = 0
h.ha.Initialize(h.params)

h.hb = &hashRolling{jump: 1}
common_b = h.hb.Common()
common_b.params = h.params.hasher
common_b.is_prepared_ = false
Expand All @@ -78,27 +70,27 @@ func (h *H35) Prepare(one_shot bool, input_size uint, data []byte) {
h.hb.Prepare(one_shot, input_size, data)
}

func (h *H35) Store(data []byte, mask uint, ix uint) {
func (h *hashComposite) Store(data []byte, mask uint, ix uint) {
h.ha.Store(data, mask, ix)
h.hb.Store(data, mask, ix)
}

func (h *H35) StoreRange(data []byte, mask uint, ix_start uint, ix_end uint) {
func (h *hashComposite) StoreRange(data []byte, mask uint, ix_start uint, ix_end uint) {
h.ha.StoreRange(data, mask, ix_start, ix_end)
h.hb.StoreRange(data, mask, ix_start, ix_end)
}

func (h *H35) StitchToPreviousBlock(num_bytes uint, position uint, ringbuffer []byte, ring_buffer_mask uint) {
func (h *hashComposite) StitchToPreviousBlock(num_bytes uint, position uint, ringbuffer []byte, ring_buffer_mask uint) {
h.ha.StitchToPreviousBlock(num_bytes, position, ringbuffer, ring_buffer_mask)
h.hb.StitchToPreviousBlock(num_bytes, position, ringbuffer, ring_buffer_mask)
}

func (h *H35) PrepareDistanceCache(distance_cache []int) {
func (h *hashComposite) PrepareDistanceCache(distance_cache []int) {
h.ha.PrepareDistanceCache(distance_cache)
h.hb.PrepareDistanceCache(distance_cache)
}

func (h *H35) FindLongestMatch(dictionary *BrotliEncoderDictionary, data []byte, ring_buffer_mask uint, distance_cache []int, cur_ix uint, max_length uint, max_backward uint, gap uint, max_distance uint, out *HasherSearchResult) {
func (h *hashComposite) FindLongestMatch(dictionary *BrotliEncoderDictionary, data []byte, ring_buffer_mask uint, distance_cache []int, cur_ix uint, max_length uint, max_backward uint, gap uint, max_distance uint, out *HasherSearchResult) {
h.ha.FindLongestMatch(dictionary, data, ring_buffer_mask, distance_cache, cur_ix, max_length, max_backward, gap, max_distance, out)
h.hb.FindLongestMatch(dictionary, data, ring_buffer_mask, distance_cache, cur_ix, max_length, max_backward, gap, max_distance, out)
}

0 comments on commit 99596c6

Please sign in to comment.