raise exception on invalid authentication (200 response from SGW)

properly initialize favorites cache (dict instead of list #24)

bid_sniper.py

@@ -166,12 +166,9 @@ def __init__(self, config: Dict, dry_run: bool = False) -> None:
         if self.bid_time_delta == datetime.timedelta(0):
             self.logger.warning("Invalid time delta string '{time_delta_str}'")
 
-        # TODO I hate this
         self.favorites_cache = {
-            "last_updated": datetime.datetime.fromisoformat("1970-01-01").astimezone(
-                ZoneInfo("Etc/UTC")
-            ),
-            "favorites": list(),
+            "last_updated": datetime.datetime(1970, 1, 1, tzinfo=datetime.timezone.utc),
+            "favorites": dict(),
         }
 
         self.scheduled_tasks = (

shopgoodwill.py

@@ -27,6 +27,7 @@ class Shopgoodwill:
         "block_size": 16,
     }
     FAVORITES_MAX_NOTE_LENGTH = 256
+    INVALID_AUTH_MESSAGE = "The username or password are incorrect"
 
     def shopgoodwill_err_hook(self, res: Response, *args, **kwargs) -> None:
         res.raise_for_status()
@@ -205,12 +206,16 @@ def login(self, username: str, password: str):
 
         self.shopgoodwill_session.hooks["response"] = self.shopgoodwill_err_hook
 
-        res = self.shopgoodwill_session.post(
+        res_json = self.shopgoodwill_session.post(
             Shopgoodwill.API_ROOT + "/SignIn/Login", json=login_params
-        )
+        ).json()
+
+        if res_json["message"] == Shopgoodwill.INVALID_AUTH_MESSAGE:
+            raise Exception("Invalid credentials")
+
         self.shopgoodwill_session.headers[
             "Authorization"
-        ] = f"Bearer {res.json()['accessToken']}"
+        ] = f"Bearer {res_json['accessToken']}"
         # TODO deal with refresh token
 
         return True