Update and fix failing tests, identify Mocha globals, and cleanup readme #68
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a combination of commits I prepared locally before an attempt to push revealed
master
is a protected branch. 😓 The changes are atomic and (hopefully) self-explanatory, but in short, theyjs2-mode
so functions likedescribe()
andit()
aren't flagged as errors$NPM
variable set in one's environment points to thenpm(1)
binary; I have$NPM
set to/usr/local/lib/node_modules
, so runningmake
quickly failed.Note that it's still possible to override variables on a case-by-case basis like this:
$ make NPM=/path/to/npm CASK=/path/to/cask install
I'll endeavour to keep future maintenance a little more review-friendly. 😉
/cc @scottaj