feat(slabtop): new completion #1247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akinomyoga
approved these changes
Sep 16, 2024
|
Do you think it's better to have this here and not in procps-ng? Edit: I see that we already have a lot of completions for stuff from there, so I guess it makes sense to continue ding that? Also presumably there are a lot of implementations of these type of commands, like |
yedayak
approved these changes
Sep 24, 2024
|
Yes, in principle I'd like to see these upstream, but as we already have a bunch and upstream has none, I think it's fine to continue that for now. Could ping upstream sometime though if they'd be interested in taking them over though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.