Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: Use lazy_loader for lazy loading of submodules #596

Merged
merged 10 commits into from
Feb 4, 2025
Merged

Conversation

SimonHeybrock
Copy link
Member

This is @MridulS change from #595 + tox -e deps.

Fixes #594.

@@ -31,6 +31,7 @@ dynamic = ["version"]
# Run 'tox -e deps' after making changes here. This will update requirement files.
# Make sure to list one dependency per line.
dependencies = [
"lazy_loader",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think Mantid tests are failing because you also need to add lazy_loader to the .buildconfig file?

@SimonHeybrock
Copy link
Member Author

@MridulS Docs builds are failing, can you have a look?

---------------------------------------------------------------------------
AttributeError                            Traceback (most recent call last)
Cell In[9], line 2
      1 wavelength_graph_monitor = {
----> 2     **scn.conversion.graph.beamline.beamline(scatter=False),
      3     **scn.conversion.graph.tof.elastic_wavelength('tof'),
      4 }

File ~/micromamba/envs/ubuntu-latest/lib/python3.10/site-packages/lazy_loader/__init__.py:94, in attach.<locals>.__getattr__(name)
     92     return attr
     93 else:
---> 94     raise AttributeError(f"No {package_name} attribute {name}")

AttributeError: No scippneutron attribute conversion

@SimonHeybrock
Copy link
Member Author

Thanks @MridulS, latest changes LGTM.

@SimonHeybrock SimonHeybrock merged commit 61c0a10 into main Feb 4, 2025
5 checks passed
@SimonHeybrock SimonHeybrock deleted the lazy branch February 4, 2025 04:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Slow import times
3 participants