Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Protocols in typing #326

Merged
merged 3 commits into from
Apr 17, 2024
Merged

Protocols in typing #326

merged 3 commits into from
Apr 17, 2024

Conversation

nvaytet
Copy link
Member

@nvaytet nvaytet commented Apr 17, 2024

Fixes #318

Copy link
Member

@jl-wynen jl-wynen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I'm no type checker. How far are we from running mypy here?

@nvaytet
Copy link
Member Author

nvaytet commented Apr 17, 2024

LGTM but I'm no type checker. How far are we from running mypy here?

Very far, but maybe a good maintenance task to carry out?
See also #321

@nvaytet nvaytet merged commit e8b49be into main Apr 17, 2024
3 checks passed
@nvaytet nvaytet deleted the protocols-in-typing branch April 17, 2024 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move protocols from backends to core.typing
2 participants