Refactor gui #126
Closed
Refactor gui #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…opy of selected row in Autoreduction table, blank if none selected, moved add/remove row buttons to Manual table
…comment box. contains workarounds, needs better handling of plopp, LogY toggle not working
|
Did you update max-python version to 3.13 because it's needed for specific gui features or is it irrelevant...? |
|
Not sure, I don't think so, do you think it's better to keep it at 3.12? This PR will be closed and these changes merged in https://github.com/paracini/essreflectometry. |
|
I think it's fine, I just asked if it's worth taking note about python 3.13 or not. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a refactor of #121 that attempts to decouple some of the components in the GUI