Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split interface of StreamProcessor into two parts #175

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

SimonHeybrock
Copy link
Member

@SimonHeybrock SimonHeybrock commented Feb 4, 2025

This change is motivated by an updated understanding of how we want to use StreamProcessor in Beamlime. In particular, we may want to add chunks "eagerly" (so expensive compute can start) instead of "lazily" (when we want to get an updated result plot). This is to reduce latency and improve throughput.

To avoid performing potentially expensive post-accumulation computation with every added chunk, I split StreamProcessor.add_chunk into two methods. I also added an allow_bypass flag. This is a useful feature that was "on" by default in the previous implementation, but during discussion with @YooSunYoung we discovered that it can have unintended consequences and is risky when used without care (see also docstring). Is it thus off by default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Selected
Development

Successfully merging this pull request may close these issues.

2 participants