Fall back to opening HDF5 files w/o locking #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jl-wynen
force-pushed
the
open-wo-locking
branch
from
ec8f4ea to
ecabf08
Compare
SimonHeybrock
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #99
Please make sure you understand the comment.
I tested manually on the login node with CODA data and it worked. Unfortunately, I don't see a feasible way to automatically test this in CI. We would have to mount a read-only filesystem. I can look into that if you think it is worth the effort.
I benchmarked this implementation vs. disabling locking directly by setting
locking=Falsewhen calling_open_nexus_file. And I did not see a time difference.