Load SUMO coordinate from GEANT4 CSV files #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jl-wynen
changed the title
jl-wynen
force-pushed
the
geant4-load-sumos
branch
2 times, most recently
from
8ce50f6 to
81e3b3f
Compare
jl-wynen
force-pushed
the
geant4-load-sumos
branch
from
81e3b3f to
337f23d
Compare
YooSunYoung
reviewed
Sep 19, 2024
| @@ -90,10 +91,14 @@ def group(key: str, da: sc.DataArray) -> sc.DataArray: | |||
| if key in ["high_resolution", "sans"]: | |||
| # Only the HR and SANS detectors have sectors. | |||
| res = da.group("sector", *elements) | |||
| elif key in ["endcap_backward", "endcap_forward"]: | |||
| # Other banks only have a single SUMO. | |||
| res = da.group("sumo", *elements) | |||
There was a problem hiding this comment.
Even if other banks only have a single SUMO, we can still group them by SUMO, no...?
There was a problem hiding this comment.
We can. But that would be the use? This extra dimension would get in the way of plotting and would always have to be sliced out.
There was a problem hiding this comment.
Yeah, I wasn't sure how many times we have to filter the endcap for this reason.
If it's not in many places, I think not-grouping is fine.
YooSunYoung
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on an implementation by @celinedurniak, see also #83.