Add support for selecting a TOA range in detector plots #304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jokasimr
approved these changes
Feb 5, 2025
| if (toa_range := self._toa_range()) is None: | ||
| return data | ||
| low, high = toa_range | ||
| return data.bins.assign_coords(toa=data.bins.data).bins['toa', low:high] |
There was a problem hiding this comment.
I need some explanation here 😄
- What is
data? (What shape shape and what fields is it expected to have?) - Why do we need to assign coords?
- Why is
toa=data.bins.data?
| options=[ | ||
| {'label': 'Filter by time-of-arrival [μs]', 'value': 'enabled'} | ||
| ], | ||
| value=[], |
There was a problem hiding this comment.
(minor) checklist is slightly odd for what seems to be a "toggle" on/off, maybe consider https://dash.plotly.com/dash-daq/booleanswitch
nvaytet
reviewed
Feb 6, 2025
Comment on lines
+149
to
+150
| sc.scalar(value['low'], unit=value['unit']).to(unit='ns'), | ||
| sc.scalar(value['high'], unit=value['unit']).to(unit='ns'), |
There was a problem hiding this comment.
Will the unit always be 'ns', or should we instead just store floats and use the units of data.bins.coords['toa'] in apply_toa_range below?
| dcc.Checklist( | ||
| id='toa-checkbox', | ||
| options=[ | ||
| {'label': 'Filter by time-of-arrival [μs]', 'value': 'enabled'} |
There was a problem hiding this comment.
It seems it's microseconds here and nanoseconds above?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #305.