Requested Noise Wave PR2 from commit 1 #597
Conversation
|
Great, thank you :) |
There was a problem hiding this comment.
@mbe9a thank you for making this slice of PR. Except the formatting, is the only addition concerns set_noise_a ?
|
|
||
| # from matplotlib import cm | ||
| # import matplotlib.pyplot as plt | ||
| # import matplotlib.tri as tri | ||
| # from scipy.interpolate import interp1d |
| raise ValueError("The network must have two or more ports.") | ||
|
|
||
| # if n-port ntwk is passive, calculate noise figure via Bosma's Thm | ||
| if passive and self.noise is None: |
There was a problem hiding this comment.
would self.noise is None and not noisy would have the same effect ? (the later maybe being more clear)
|
|
||
| def nf(self, z: NumberLike, passive=False, Ta=290, Tp=290) -> npy.ndarray: | ||
| """ | ||
| the noise figure for the network if the source impedance is z |
There was a problem hiding this comment.
Could you add a few words and a reference to the theorem you use to calculate the NF if not defined in the ntwk?
| if f_stop < self.frequency.f_scaled[ | ||
| stop_idx]: # we don't want the stop index to be at a frequency higher than `f_stop` |
There was a problem hiding this comment.
@mbe9a Did you use black for formatting?
| ((z01.conj() + s[:, 0, 0] * z01) * (1 - s[:, 1, 1]) + s[:, 0, 1] * s[:, 1, 0] * z01) / denom, | ||
| ((1 - s[:, 0, 0]) * (1 - s[:, 1, 1]) - s[:, 0, 1] * s[:, 1, 0]) / denom, |
There was a problem hiding this comment.
While I understand the change from s[:,m,n] to s[:, m, n], I'm not sure if this helps to read in such cases...
There was a problem hiding this comment.
I'd say it's fine to change, as the latter is pep8 conform. (E231)
https://www.flake8rules.com/rules/E231.html
As requested, a second PR from my initial commit. This is probably just formatting changes from PyCharm and includes one noise figure function change.