Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for compressed handles #274

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Conversation

gab1one
Copy link
Contributor

@gab1one gab1one commented Jul 7, 2017

This PR adds support for compressed handles, that operate on archives: namely .zip, .gzip and bzip2 archives.

This requires #339 and #340 to be merged first.

@gab1one gab1one force-pushed the more-handles-compressed branch 2 times, most recently from 71141df to 45fe1fb Compare July 11, 2017 10:57
@ctrueden ctrueden force-pushed the more-handles-compressed branch from 45fe1fb to 14ec66b Compare July 11, 2017 17:20
@gab1one gab1one force-pushed the more-handles-compressed branch from 14ec66b to 5743fa2 Compare July 17, 2017 11:39
@gab1one gab1one force-pushed the more-handles-compressed branch from 5743fa2 to b710f33 Compare August 12, 2017 17:24
@ctrueden ctrueden force-pushed the more-handles-compressed branch from b710f33 to ff9f379 Compare August 31, 2017 16:16
@ctrueden
Copy link
Member

  • We should consider using Apache Commons Compress to read (and maybe write, though less important) these formats and more.
  • The locations should implement BrowsableLocation (as currently on master) such that code that works on arbitrary BrowsableLocation can work with no changes with these compressed formats.
  • ZipEntry is a lot like File, including stuff like last modified datestamp, which corresponds to DataHandle in our paradigm. So a ZipEntryHandle would make sense.
  • The ZipLocation points at a Location corresponding to the ZIP data. Its parent() method returns null. (It could return the containing folder of the zip, but this has pros and cons. We should perhaps experiment with that.)
  • A ZipElementLocation (naively, ZipEntryLocation, but it does not use java.util.zip.ZipEntry!) would have a parent ZipLocation together with a String for the entry name. It is not stateful.

@gab1one gab1one force-pushed the more-handles-compressed branch from ff9f379 to c88632a Compare October 24, 2017 15:12
@gab1one gab1one force-pushed the more-handles-compressed branch from 74f0a3a to 9a91f38 Compare October 15, 2018 13:47
@gab1one gab1one mentioned this pull request Oct 15, 2018
@gab1one gab1one changed the title Port support for Compressed Handles from scifio WIP: Port support for Compressed Handles from scifio Oct 15, 2018
@gab1one gab1one force-pushed the more-handles-compressed branch 2 times, most recently from cbfe09d to ad90f9e Compare October 16, 2018 11:48
@ctrueden
Copy link
Member

@gab1one What is the status of this PR now?

@ctrueden ctrueden force-pushed the more-handles-compressed branch from ad90f9e to bfc517a Compare November 12, 2021 22:11
@ctrueden ctrueden changed the title WIP: Port support for Compressed Handles from scifio Add support for compressed handles Nov 12, 2021
@ctrueden
Copy link
Member

I rebased this over the latest master, removing one commit that was obsolete (which fixed the handling of unknown lengths in an incompatible way with a different fix that was already merged). @hinerm I'd value your input on this PR at some point when you have time. No rush though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants