Update CMakeLists.txt #1844
Closed
Update CMakeLists.txt #1844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Factored Repeated Flags Moved repeated warning disable flags (/wd4100 /wd4189 /wd4065, etc.) into a single BASE_MSVC_FLAGS. Debug vs. Release Separated DEBUG_FLAGS and RELEASE_FLAGS for clarity, and appended them appropriately. Removed Repetition Avoided rewriting the set(CMAKE_CXX_FLAGS) lines multiple times for each library, using a consistent approach across both freetype and harfbuzz. Essential Logic Retained The if(WIN32) block sets flags for MSVC or Clang on Windows. The same flags are still there, just organized more succinctly. Comments and Organization Added short comments (e.g., # Additional debug flags) to clarify which lines do what, improving readability without altering behavior. No Behavior Changes The final compiled flags are effectively the same, preserving the original settings for debug vs. release and for Clang vs. MSVC.
|
Hey, so we have been dealing with an influx of drive-by AI PRs lately. I encourage you to drop by the discord to say "hi" so that we know that there is a real person behind this. We are very friendly, I promise. |
|
ok will do |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Factored Repeated Flags
Moved repeated warning disable flags (/wd4100 /wd4189 /wd4065, etc.) into a single BASE_MSVC_FLAGS. Debug vs. Release
Separated DEBUG_FLAGS and RELEASE_FLAGS for clarity, and appended them appropriately. Removed Repetition
Avoided rewriting the set(CMAKE_CXX_FLAGS) lines multiple times for each library, using a consistent approach across both freetype and harfbuzz. Essential Logic Retained
The if(WIN32) block sets flags for MSVC or Clang on Windows. The same flags are still there, just organized more succinctly. Comments and Organization
Added short comments (e.g., # Additional debug flags) to clarify which lines do what, improving readability without altering behavior. No Behavior Changes
The final compiled flags are effectively the same, preserving the original settings for debug vs. release and for Clang vs. MSVC.