Economy balance tweaks #1809
Merged
Economy balance tweaks #1809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ineveraskedforthis
commented
Nov 30, 2024
ineveraskedforthis
commented
- Less greedy artisans
- Need weights are set to 1 to encourage consumption of actual goods instead of coal
- Cull trade routes more aggressively to avoid 1 Jan freeze
- Tweak some numbers
schombert
reviewed
Nov 30, 2024
src/economy/economy.cpp
Outdated
| @@ -1028,6 +1028,7 @@ void rebalance_needs_weights(sys::state& state, dcon::market_id n) { | |||
| } | |||
| auto& w = state.world.market_get_life_needs_weights(n, c); | |||
| w = ideal_weighting * state.defines.alice_need_drift_speed + w * (1.0f - state.defines.alice_need_drift_speed); | |||
| w = 1.f; | |||
There was a problem hiding this comment.
Did you mean to write this? It seems to completely discard the previous calculation. If you want to keep the old calculation around, I suggest commenting it out so that the linter won't complain
There was a problem hiding this comment.
Yes, the plan was to discard it. Will comment out old calculation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.