Location prefix behind reverse proxy + Button For Reload Configuration #53
Conversation
schenkd
added
documentation
There was a problem hiding this comment.
Hey @bifeldy, thank you very much for your contribution!
I'm about to accept this PR if you adapt the volume mounts in the README.md to a unix path and remove the docker-compose.windows.yml.
I can understand to have this one in your private repo, but in this I don't want to support any windows specific adjustments since I don't have a windows system to test things on.
Thank you very much :)
docker-compose.windows.yml
Outdated
|
|
||
| bifeldy-net: | ||
| name: bifeldy-net | ||
| external: true |
There was a problem hiding this comment.
Hey @bifeldy, could you please remove this one? It's not generic since it's assumes that
- a drive D:/ is always the target to mount
- you are using your username as a network name
btw. everything that's in the repo need maintenance and I don't want to support on issues with docker-compose and windows.
I'm okay with adding it in a seperate section in the README.md to provide an example for people that are using windows.
Best David
README.md
Outdated
| # ports: | ||
| # - 8080:8080 | ||
| volumes: | ||
| - D:/_data/_docker/nginx:/etc/nginx |
There was a problem hiding this comment.
Could you adjust the volume mounts to a unix path? I don't want to get requests related to windows support since I don't have a windows machine where I could test it. Thanks mate!
|
Hi @schenkd Hopefully, you check the newly updated file Thanks. |
bifeldy
changed the title
Hello
I'm continuing #52
Example already on readme.md file
Thanks.